Skip to content

Conversation

@timmo001
Copy link
Member

@timmo001 timmo001 commented Oct 9, 2025

Breaking change

Proposed change

Pulls in stats used in storage panel to estimate the backup size. Also estimates the compressed size based on gzip compression (.tar.gz)

image

Currently there is no way to pull individual addon size (from what I could find), so this is added to the disclaimer when custom is selected and 1-max addons is selected:

image image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@timmo001 timmo001 added the Needs UX Pull requests requiring a review from the Home Assistant design team label Oct 9, 2025
@timmo001
Copy link
Member Author

timmo001 commented Oct 14, 2025

  • Remove uncompressed size
  • Different component to use, @matthiasdebaat to provide
  • Supervisor will be looked at in future for addon sizes

@timmo001 timmo001 removed the Needs UX Pull requests requiring a review from the Home Assistant design team label Oct 14, 2025
import memoizeOne from "memoize-one";
import { isComponentLoaded } from "../../../../../common/config/is_component_loaded";
import { fireEvent } from "../../../../../common/dom/fire_event";
import "../../../../../components/ha-alert";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer used?

return nothing;
}

const result = this._estimateBackupSize(data);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this a memoized function and pass _storageInfo to it.

timmo001 and others added 2 commits October 14, 2025 14:07
…ta.ts

Co-authored-by: Bram Kragten <mail@bramkragten.nl>
@timmo001 timmo001 requested a review from bramkragten October 14, 2025 13:45
@bramkragten bramkragten merged commit 4808463 into dev Oct 14, 2025
15 checks passed
@bramkragten bramkragten deleted the backup-settings-estimated-size branch October 14, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants